Bug in io.jmix.data.impl.dbms.HsqlSequenceSupport

fsuperga · August 24, 2023, 6:50am

jmix-framework/jmix/blob/e2a086e743e89416cc92b6f5adcfae5d2c74ae7d/jmix-data/data/src/main/java/io/jmix/data/impl/dbms/HsqlSequenceSupport.java#L53

      
        
                public String deleteSequenceSql(String sequenceName) {
                    return "drop sequence " + (sequenceName != null ? sequenceName.toUpperCase() : null);
                }
            
            
    @Override
                public String getNextValueSql(String sequenceName) {
                    return "call next value for " + sequenceName;
                }
            
            
    @Override
                public String getCurrentValueSql(String sequenceName) {
                    return "select START_WITH from INFORMATION_SCHEMA.SYSTEM_SEQUENCES where SEQUENCE_NAME = '"
                            + sequenceName.toUpperCase() + "'";
                }
            }

public String getCurrentValueSql(String sequenceName) {
        return "select START_WITH from INFORMATION_SCHEMA.SYSTEM_SEQUENCES where SEQUENCE_NAME = '"
                + sequenceName.toUpperCase() + "'";
    }

calling getCurrentValueSql returns always the sequence’ starting value instead of the current value.

I think it would work by replacing sql code with:
"call current value for '" + sequenceName.toUpperCase() + "'";

or

"select (CAST(next_value AS INTEGER) - 1) from INFORMATION_SCHEMA.SYSTEM_SEQUENCES where SEQUENCE_NAME = '" + sequenceName.toUpperCase() + "'";

taimanov · August 29, 2023, 9:26pm

Hello Fulvio,

Thank you for reporting the problem and suggesting solutions! The issue has been created.

Regards,
Dmitry