Dynamic Attributes : Bug in rendering lookup field when attribute is entity type and is collection

cedric.deprez · June 15, 2022, 4:44pm

Hi guys !

Thank you for you great framework !

By doing some tests on dynamic attributes I encountered a bug in this specific configuration:

Creating a dynamic attribute of type ‘Entity’
Selecting ‘Lookup field’ = true
Selecting ‘IsCollection’ = true

Creation itself is ok but when trying to create or edit an entity on the UI I got this error message:
IllegalStateException: Unable to find action with id values_select

After a small debug exercice I think I found the source of the bug:

github.com

jmix-framework/jmix/blob/master/jmix-dynattr/dynattr-ui/src/main/java/io/jmix/dynattrui/impl/factory/DynAttrComponentGenerationStrategy.java

/*
 * Copyright 2020 Haulmont.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package io.jmix.dynattrui.impl.factory;

import com.google.common.base.Splitter;
import com.google.common.base.Strings;

This file has been truncated. show original

In the class io.jmix.dynattrui.impl.factory.DynAttrComponentGenerationStrategy it looks like there is a small problem in the method
createCollectionField

The select action is added to the values picker at line 187:
valuesPicker.addAction(selectAction);
while line 184 is already trying to use this action:
setValuesPickerOptionsLoader(valuesPicker, attribute, valueSource);

I have done a small test pushing the addAction call before line 184 and it seems to work well for me.

I don’t know enough the framework to be sure that it is the right way to correct this bug but I hope this can help.

Best regards,

Cedric

krivopustov · June 20, 2022, 2:13pm

Hi Cedric,

Thank you for the report and thorough investigation!
Looks like you have enough information to create an issue. PRs are also welcome

Regards,
Konstantin

s0506777 · June 6, 2023, 11:54am

Was the problem solved already? For what version?
For jmix 1.4.4 it actual still.

krivopustov · June 7, 2023, 8:09am

Perhaps no. Please create an issue at Github.