Menu Item not active - wrong urlQueryParameters usage

jakub.cech · October 6, 2023, 2:50pm

Hello guys,

Using latest jmix 2.0.2 I have trouble with menu. No item is marked selected. never. I would like to have it selected as in https://demo.jmix.io/ui-samples/ .

So I did some debugging and I found out that HighlightConditions.sameLocation() is always false because RouterLink.getHref() is always ending with “?” . So it compares “customers” with “customers?”.

github.com

vaadin/flow/blob/9d5165bbc9a3a70fccfb13784df6158764795b2f/flow-server/src/main/java/com/vaadin/flow/router/HighlightConditions.java#L36

      
        
            
            
private HighlightConditions() {
            }
            
            
/**
             * Highlight if the navigation path is the same as the target
             * {@link RouterLink}.
             *
             * @return the highlight condition
             */
            public static HighlightCondition<RouterLink> sameLocation() {
                return (link, event) -> event.getLocation().getPath()
                        .equals(link.getHref());
            }
            
            
/**
             * Highlight if the navigation path starts with the target
             * {@link RouterLink} path.
             *
             * @return the highlight condition
             */

So I dig a bit more and find out that question mark is added in RouterLink, because queryparams are not null, but empty:

github.com

vaadin/flow/blob/8324936409f842226616f4a3e5ee2bc3f1ce7bca/flow-server/src/main/java/com/vaadin/flow/router/RouterLink.java#L433

      
        
                this.queryParameters = queryParameters;
                updateHref(getHref());
            }
            
            
private void updateHref(String url) {
                int startOfQuery = url.indexOf('?');
                if (startOfQuery >= 0) {
                    url = url.substring(0, startOfQuery);
                }
                if (queryParameters != null) {
                    url += '?' + queryParameters.getQueryString();
                }
                HREF.set(this, url);
            }
            
            
private Router getRouter() {
                return ComponentUtil.getRouter(this);
            }
            
            
/**
             * Gets the {@link HighlightCondition} of this link.

Fix was done here:

In jmix is always called ListMenuBuilder.createViewMenuItem() and there JmixListMenu.ViewMenuItem .withUrlQueryParameters() which always sets urlQueryParams nonnull.

I want to ask for suggestion how to fix it in JMIX app. Is there way how to work around this? Maybe there is a way how to configure menu differently? How it is that it is working in UI samples? Or wait for version with upgraded Vaadin?

Thank you,
Jakub

gorelov · October 31, 2023, 9:42am

Hi,

the upcoming Jmix v2.1 doesn’t have this problem. 2.1.0-RC1 is already available.

Screenshot 2023-10-31 at 13.42.04

Regards,
Gleb

jakub.cech · November 9, 2023, 1:41pm

Yes, I can confirm that in 2.1. I dont have this problem. Thank you